Regression in 2.14.0

[Artur-]

git clone https://github.com/vaadin/flow.git
cd flow
mvn versions:set -DnewVersion=1.2.3

Expected outcome:
All modules are set to version 1.2.3, like with 2.13.0

Actual outcome:

[ERROR] 
java.nio.file.NoSuchFileException: /.../flow/flow-tests/test-npm-only-features/test-npm-bytecode-scanning/pom.xml
    at sun.nio.fs.UnixException.translateToIOException (UnixException.java:92)
    at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:106)
    at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:111)
    at sun.nio.fs.UnixFileSystemProvider.newByteChannel (UnixFileSystemProvider.java:219)
    at java.nio.file.Files.newByteChannel (Files.java:380)
    at java.nio.file.Files.newByteChannel (Files.java:432)
    at java.nio.file.spi.FileSystemProvider.newInputStream (FileSystemProvider.java:422)
    at java.nio.file.Files.newInputStream (Files.java:160)
    at org.codehaus.plexus.util.xml.XmlReader.<init> (XmlReader.java:129)
    at org.codehaus.plexus.util.xml.XmlStreamReader.<init> (XmlStreamReader.java:67)
    at org.codehaus.plexus.util.ReaderFactory.newXmlReader (ReaderFactory.java:122)
    at org.codehaus.mojo.versions.api.PomHelper.readXmlFile (PomHelper.java:1498)
    at org.codehaus.mojo.versions.AbstractVersionsUpdaterMojo.process (AbstractVersionsUpdaterMojo.java:326)
    at org.codehaus.mojo.versions.SetMojo.execute (SetMojo.java:381)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)

and the version in the following modules is not updated:

flow-tests/test-ccdm-flow-navigation/pom-production.xml
flow-tests/test-ccdm/pom-production.xml
flow-tests/test-custom-frontend-directory/test-themes-custom-frontend-directory/pom-generatedTsDir.xml
flow-tests/test-frontend/test-npm/pom-production.xml
flow-tests/test-frontend/test-pnpm/pom-production.xml
flow-tests/test-frontend/vite-context-path/pom-production.xml
flow-tests/test-frontend/vite-embedded/pom-production.xml
flow-tests/test-frontend/vite-pwa-custom-offline-path/pom-production.xml
flow-tests/test-frontend/vite-pwa-disabled-offline/pom-production.xml
flow-tests/test-npm-only-features/test-npm-bytecode-scanning/pom-devmode.xml
flow-tests/test-npm-only-features/test-npm-bytecode-scanning/pom-prod-fallback.xml
flow-tests/test-npm-only-features/test-npm-bytecode-scanning/pom-production.xml
flow-tests/test-pwa-disabled-offline/pom-production.xml
flow-tests/test-pwa/pom-production.xml

[andrzejj0]

Gotcha. Sorry about that. I'll look into it.

[pzygielo]

I observe similar - version is not set in modules with parent not in ..

• for modules with <parent>... <relativePath>../..</relativePath>

[pzygielo]

Sorry to hijack this issue, but perhaps it's related.
For my case: 96deb8e is the first bad commit.

[pzygielo]

I suppose it has something to do with the assumptions

versions/versions-common/src/main/java/org/codehaus/mojo/versions/api/PomHelper.java

Line 1219 in efec55e

if (moduleFile.isDirectory() && new File(moduleFile, "pom.xml").isFile()) {

versions/versions-common/src/main/java/org/codehaus/mojo/versions/api/PomHelper.java

Line 1302 in efec55e

File parentFile = new File(parentDir, "pom.xml");

that pom.xml is the right file name...

[marthinmc]

I have the same problem when I do mvn versions:set, please keep us informed

java.nio.file.NoSuchFileException: /home/jenkins/agent/workspace/curve-connector-test_release_0.2/dtos
13:05:59 at sun.nio.fs.UnixException.translateToIOException (UnixException.java:86)

Also have this issue

[vanroda]

Possible workarounds:

1. fixate plugin version in parent pom
   <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>versions-maven-plugin</artifactId> <version>2.13.0</version> </plugin>

OR

2. add version to the set cmd
   mvn -q -f pom.xml org.codehaus.mojo:versions-maven-plugin:2.13.0:set

[marthinmc]

Possible workarounds:

1. fixate plugin version in parent pom
   <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>versions-maven-plugin</artifactId> <version>2.13.0</version> </plugin>
2. add version to the set cmd
   mvn -q -f pom.xml org.codehaus.mojo:versions-maven-plugin:2.13.0:set

it works for me! thanks. I didn't have to add it in the parent pom

[andrzejj0]

@pzygielo could you please share some details about your case? Alternatively, could you try your test case against my branch? Thanks

The old assumption about the "pom.xml" file in module directories dates back to the very beginning of the Set mojo. I wonder how (if) it worked in 2.13.0 (the mojo simply skipped files it couldn't resolve). Anyway, the original case as well a simplified case (it-set-issue-848) do work fine with the branch.

And the solution is simple -- since we already have the path, why not use it? :)

Everyone -- until this is released, please use

mvn org.codehaus.mojo:versions-maven-plugin:2.13.0

to get around the problem. Sorry about the inconvenience.

[pzygielo]

could you try your test case against my branch? Thanks

2.15.0-SNAPSHOT - built from 60cda6a, works fine 🎉

---

could you please share some details about your case?

Here it is extracted to minimum:

.
├── docs
│   └── issue
│       └── pom.xml
└── pom.xml

with top-level having

    <modules>
        <module>docs/issue</module>
    </modules>

and module with

    <parent>
        ...
        <relativePath>../..</relativePath>
    </parent>

[fun2sh]

could you try your test case against my branch? Thanks

2.15.0-SNAPSHOT - built from 60cda6a, works fine 🎉

could you please share some details about your case?

Here it is extracted to minimum:

.
├── docs
│   └── issue
│       └── pom.xml
└── pom.xml

with top-level having

    <modules>
        <module>docs/issue</module>
    </modules>

and module with

    <parent>
        ...
        <relativePath>../..</relativePath>
    </parent>

This is exactly what happens. When there is an intermediate parent directory without pom.xml, it fails to version bump that. It starts looking for that module in root of the project.