Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #413 Use 'GAV' for result keys in LicensedArtifactResolver #414

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Fix #413 Use 'GAV' for result keys in LicensedArtifactResolver #414

merged 3 commits into from
Jul 2, 2023

Conversation

attilapuskas
Copy link
Contributor

Fixes #413

In the result mapping we need to use "GAV" to be compatible with
the other classes in the plugin. While the exclude/includeArtifacts
should still use the Artifact#getId, since the getDependencyTrail
also uses that format, which is considered when we exclude all the
transitive deps of excluded artifacts.

Note that the added it is based on the already existing
download-licenses-include-exclude-types, but with a small change
in the settings to use excludeTransitiveDependencies instead.

Fixes #413

In the result mapping we need to use "GAV" to be compatible with
the other classes in the plugin. While the exclude/includeArtifacts
should still use the Artifact#getId, since the getDependencyTrail
also uses that format, which is considered when we exclude all the
transitive deps of excluded artifacts.

Note that the added it is based on the already existing
download-licenses-include-exclude-types, but with a small change
in the settings to use excludeTransitiveDependencies instead.
@slawekjaranowski slawekjaranowski changed the title Use 'GAV' for result keys in LicensedArtifactResolver Fix #413 Use 'GAV' for result keys in LicensedArtifactResolver Jul 2, 2023
# Conflicts:
#	src/main/java/org/codehaus/mojo/license/download/LicensedArtifactResolver.java
@slawekjaranowski slawekjaranowski merged commit a86c98e into mojohaus:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'download licenses' goals do not exclude transitive dependencies
2 participants