Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate-add-third-party mojo is not including optional dependencies by default #303

Closed
elballa opened this issue Mar 2, 2019 · 0 comments
Closed

Aggregate-add-third-party mojo is not including optional dependencies by default #303

elballa opened this issue Mar 2, 2019 · 0 comments
Milestone
1.20

Comments

@elballa
Copy link

elballa commented Mar 2, 2019

aggregate-add-third-party mojo is not taking care of the includeOptional parameter because its value is not passed to child modules when child mojo is going to be initialized (initFromMojo method call)
elballa pushed a commit to elballa/license-maven-plugin that referenced this issue Mar 2, 2019
@balessandr
Failure test case for issue mojohaus#303
8babfb3
@ppalaga ppalaga closed this as completed in 487daa1 Mar 2, 2019
ppalaga added a commit that referenced this issue Mar 2, 2019
@ppalaga
Merge pull request #304 from elballa/feature/303
98b26ee 
Fix #303 Aggregate-add-third-party mojo is not including optional dependencies by default
@ppalaga ppalaga added this to the 1.20 milestone Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.20
Development

No branches or pull requests
2 participants
@ppalaga @elballa