Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce JAVA_HOME for ITs #295

Merged
merged 1 commit into from
May 11, 2022
Merged

Enforce JAVA_HOME for ITs #295

merged 1 commit into from
May 11, 2022

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented May 8, 2022

This envvar is explicitly used in ITs, for example

<executable>${JAVA_HOME}/bin/java</executable>

This causes somehow unfriendly failure delayed up to ITs.
Thus I propose to replace

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.1-SNAPSHOT:exec (default-cli) on project mexec-100: Command execution failed. Cannot run program "${JAVA_HOME}/bin/java"

(that one has to check in target/its/mexec-100/build.log) with earlier build failure with

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireEnvironmentVariable failed with message:
Environment variable "JAVA_HOME" is required for this build.

@pzygielo pzygielo marked this pull request as ready for review May 8, 2022 09:58
@slachiewicz slachiewicz merged commit 13164e0 into mojohaus:master May 11, 2022
@pzygielo pzygielo deleted the enfJH branch May 11, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants