Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight plugin prefix in plugin artifactId #155

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Highlight plugin prefix in plugin artifactId #155

merged 1 commit into from
Nov 22, 2022

Conversation

jcgay
Copy link
Member

@jcgay jcgay commented Nov 7, 2022

This is a draft to try the rendering of #143

@jcgay jcgay added the feature label Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022 •
edited
Loading

Test Results

40 tests  +6   40 ✔️ +6   2m 59s ⏱️ +50s
14 suites +1     0 💤 ±0 
14 files   +1     0 ❌ ±0 

Results for commit 19418ea. ± Comparison against base commit 6cc881e.

♻️ This comment has been updated with latest results.

@jcgay
Copy link
Member Author

jcgay commented Nov 7, 2022 •
edited
Loading

Is that what you had in mind @hboutemy ?

Capture d’écran 2022-11-07 à 21 09 41

I have also tried with strong rendering without being able to choose one winner 😇

Capture d’écran 2022-11-07 à 21 16 48

@hboutemy
Copy link
Member

hboutemy commented Nov 7, 2022

wow, I love it: yes, that was my intent!
I can't choose the winner either :)

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

File Coverage [89.1%] 🍏
ListMojo.java 100% 🍏
MojoExecutionDisplay.java 100% 🍏
AbstractTableDescriptor.java 100% 🍏
ListTableDescriptor.java 71.43% 🍏
Total Project Coverage 64.11% 🍏

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

File Coverage [89.58%] 🍏
ListMojo.java 100% 🍏
MojoExecutionDisplay.java 100% 🍏
AbstractTableDescriptor.java 100% 🍏
ListTableDescriptor.java 74.48% 🍏
Total Project Coverage 64.55% 🍏

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

File Coverage [89.86%] 🍏
ListMojo.java 100% 🍏
MojoExecutionDisplay.java 100% 🍏
AbstractTableDescriptor.java 100% 🍏
MavenPluginPatterns.java 100% 🍏
ListTableDescriptor.java 74.48% 🍏
Total Project Coverage 64.82% 🍏

@jcgay jcgay marked this pull request as ready for review November 9, 2022 19:13
@github-actions
Copy link

File Coverage [89.86%] 🍏
ListMojo.java 100% 🍏
MojoExecutionDisplay.java 100% 🍏
AbstractTableDescriptor.java 100% 🍏
MavenPluginPatterns.java 100% 🍏
ListTableDescriptor.java 74.48% 🍏
Total Project Coverage 64.82% 🍏

@jcgay
Copy link
Member Author

jcgay commented Nov 10, 2022 •
edited
Loading

I've gone with the green one.

At worst it can be changed with:

mvn org.codehaus.mojo:buildplan-maven-plugin:2.1.1-SNAPSHOT:list -Dstyle.mojo=bold

WDYT @hboutemy ?

@jcgay
Highlight plugin prefix in buildplan:list
f4abff9 
Respecting convention xxx-maven-plugin and maven-xxx-plugin xxx is now displayed
with the Maven mojo color style when available.

It should be easier to spot the "important" name portion for a plugin.
@github-actions
Copy link

File Coverage [89.86%] 🍏
ListMojo.java 100% 🍏
MojoExecutionDisplay.java 100% 🍏
AbstractTableDescriptor.java 100% 🍏
MavenPluginPatterns.java 100% 🍏
ListTableDescriptor.java 74.48% 🍏
Total Project Coverage 64.82% 🍏

@jcgay jcgay merged commit d9bf4e6 into master Nov 22, 2022
@jcgay jcgay deleted the highlight branch November 22, 2022 06:02
jcgay added a commit that referenced this pull request Nov 22, 2022
@jcgay
Highlight plugin prefix in buildplan:list
1436b5f 
Respecting convention xxx-maven-plugin and maven-xxx-plugin xxx is now displayed
with the Maven mojo color style when available.

It should be easier to spot the "important" name portion for a plugin.

Fixes #143, closes #155
@nyg nyg mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcgay @hboutemy