optimize gocover

mojocn · Dec 22, 2017 · f89cae0 · f89cae0
1 parent 3243e42
commit f89cae0
Show file tree

Hide file tree

Showing 4 changed files with 273 additions and 323 deletions.
diff --git a/captcha.go b/captcha.go
@@ -71,11 +71,8 @@ func CaptchaWriteToFile(cap CaptchaInterface, outputDir, fileName, fileExt strin
 		return err
 	}
 	defer file.Close()
-	if _, err = cap.WriteTo(file); err == nil {
-		return nil
-	} else {
-		return err
-	}
+	_, err = cap.WriteTo(file)
+	return err
 }
 
 //CaptchaItem captcha basic information.

diff --git a/captcha_test.go b/captcha_test.go
@@ -77,9 +77,10 @@ func TestCaptchaWriteToBase64Encoding(t *testing.T) {
 func TestVerifyCaptcha(t *testing.T) {
 	idkey, _ := GenerateCaptcha("", configD)
 	verifyValue := globalStore.Get(idkey, false)
-	if verifyValue == "" {
-		t.Error("verify captcha content is failed.")
+	if VerifyCaptcha(idkey, verifyValue) {
+		t.Log(idkey, verifyValue)
 	} else {
-		t.Log(verifyValue)
+		t.Error("verify captcha content is failed.")
+
 	}
 }