feat(mojaloop/#2796): duplicate transaction not getting callback for post /bulkTransfers #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…post /bulkTransfers fix(mojaloop/##2796): duplicate transaction not getting callback for post /bulkTransfers - mojaloop/project#2796 - added 'BULK_PREPARE_DUPLICATE' event enum action type
- updated dependencies - replace npm-audit-resolver with audit-ci - updated CI config for audit-ci changes - added audit-ci.jsonc and updated allowList - refactored .ncurc.js to .ncurc.yaml - added header comment to .ncurc.yaml
…post /bulkTransfers feat(mojaloop/#2796): duplicate transaction not getting callback for post /bulkTransfers - mojaloop/project#2796 - updated duplicateCheckComparator to suppose overriding the generatedHash calculation to accomodate Bulk Transfer Prepare/Fulfil use-cases - updated unit tests to validate the above change
…-transaction-not-getting-callback-for-post-bulkTransfers # Conflicts: # package-lock.json # package.json
mdebarros
requested review from
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
kleyow
previously approved these changes
Aug 10, 2022
elnyry-sam-k
previously approved these changes
Aug 10, 2022
…itional config params
elnyry-sam-k
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2796): duplicate transaction not getting callback for post /bulkTransfers - mojaloop/project#2796
generatedHashcalculation to accommodate Bulk Transfer Prepare/Fulfil use-caseschore: maintenance dependencies