fix(settlements)!: SettlementModel currency is mandatory #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: currency is mandatory on /post settlementModels creation of settlementModel on startup has been removed
vgenev
changed the title
vgenev
changed the title
mdebarros
requested changes
Jan 22, 2021
mdebarros
previously approved these changes
Jan 25, 2021
vgenev
requested review from
elnyry-sam-k,
lewisdaly,
oderayi and
vijayg10
as code owners
|
Nice title! |
ggrg
pushed a commit
to ggrg/central-ledger
that referenced
this pull request
Mar 6, 2021
* WIP participantcurrency_pcl_unique error when creating participant * WIP * WIP * allow multiple settlementModels * fix: settlementModel has currency as required BREAKING CHANGE: currency is mandatory on /post settlementModels creation of settlementModel on startup has been removed * added codeowners * cleaned and added comments and descriptions * added more info on API * added a commentS * dependencies update Co-authored-by: Shashikant Hirugade <shashi.pioneer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: settlementModel has currency as required
BREAKING CHANGE: currency is mandatory on /post settlementModels
creation of settlementModel on startup has been removed