Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#332 Settlement Processing DB Design #115

Merged
merged 8 commits into from
Aug 15, 2018
Merged

Feature/#332 Settlement Processing DB Design #115

merged 8 commits into from
Aug 15, 2018

Conversation

ggrg
Copy link
Member

@ggrg ggrg commented Aug 8, 2018

Added all new settlement tables to migration scripts as per design sessions with @wdcmb;
Cleaned up unused tables and transfer states seeds + scripts;
Added seeds for the settlement states;
Added migrations for previous story (segment and transferTimeout);
Changed reason in transferStateChange from TEXT to VARCHAR(512);
Everywhere reason column appears is declared as VARCHAR(512);
Added foreign keys, indexes and unique indexes as per design;
Ensured DB Model matches migration scripts.
Story #332

@ggrg ggrg requested review from NicoDuvenage, mdebarros, HenkKodde and wdcmb and removed request for NicoDuvenage and wdcmb August 8, 2018 19:29
@ggrg ggrg self-assigned this Aug 10, 2018
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ggrg ggrg merged commit df33516 into mojaloop:develop Aug 15, 2018
@ggrg ggrg deleted the feature/#332SettlementProcessingDbDesign branch August 15, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants