You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fix still generates a wrong URL in the example mentioned in #2310:
{: page-href="wiki:///help-common/audio.mp3" lang="en" dir="ltr" data-href="/help-common/audio.mp3" class="moin-transclusion"}
The expected markdown is {: page-href="wiki:///help-common/audio.mp3" lang="en" dir="ltr" data-href="/help-common/audio.mp3" class="moin-transclusion"}
Thanks for the concrete example. I pushed 9b500dd5, which now prefers data-href for expanded transclusions even when an xinclude:href is present, and uses the source filename instead of the browser fallback text for expanded audio/video objects.
I added a regression case matching the reported audio shape. Fresh checks on the pushed commit:
focused Markdown converter suite: 71 passed
Ruff check on the changed files
git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+getURL.do=showquery and leading slash before writing editable Markdown.Testing
pytest -q src/moin/converters/_tests/test_markdown_out.py src/moin/converters/_tests/test_markdown_in_out.py(141 passed)pytest -qwith the virtual environment onPATH(2031 passed, 17 skipped, 1 xpassed)ruff check src/moin/converters/markdown_out.py src/moin/converters/_tests/test_markdown_out.pyblack --check src/moin/converters/markdown_out.py src/moin/converters/_tests/test_markdown_out.pygit diff --check upstream/master...HEADFixes #1298