Tests for Markdown HTML markup with embedded Markdown markup. - #2178
Merged
Conversation
- Re-sort HTML markup tests. - Add samples for HTML tags with standard attributes. - More samples for Markdown in HTML. Remove duplicate sample: <del> without markdown is already tested.
Add samples for to-be-ignored HTML markup. Add Babel configuration to avoid exception from log message localisation.
Additional tests for PR moinwiki#2166 Some valid use cases still fail. TODO: fix behaviour and move samples to the non-failing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #2166 fixed some cases of inline HTML tags/elements with
embedded Markdown (issue #1838).
Unfortunately, there are a number of valid use cases that still fail or show a different behaviour from the same HTML tag without embedded Markdown.
This PR adds test samples for them
(it also updates and sorts the markdown-in tests).
A partial fix is locally available, however, it increases the already high
amount of code duplication.
We should discuss options for better integration with the upstream
markdown and html parsers as well as the Moin html_in converter.