-
Notifications
You must be signed in to change notification settings - Fork 16
Include JSONFormatter in bundle #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
very nice! I'll merge it tonight |
@mohsen1 and updates on merging this and publishing a new version to npm? |
Hey @mhamann this is great but we need to make sure it works end-to-end I would like to move away from bower and gulp and instead build it with webpack and test it with Jest Can you look into it? Thanks! |
@mohsen1 yeah, i can try to find some time to work on that. (cc: @chrisdudley - maybe someone from your team could collab w/ me on this) I see the PR was reverted. Did something break? I did run some manual tests to ensure this worked and solved the issue--and it did. But certainly could break people if they were depending on the bower side of things. This probably deserves a |
The bower dependencies were still in the demo app. What I wish I could do is to have webpack dev server for demo and webpack for building the js/css assets |
Gotcha. Webpack dev server shouldn't be a problem. |
I tried the version at this commit (1f87948) and I can use it in my code with npm + browserify with:
On the current master branch (with commit reverted) I cannot because it does not find One thing I had to add was json-formatter-js dependency, which was not automatically installed. |
"webpack": "^3.8.1", | ||
"webpack-stream": "^4.0.0" | ||
}, | ||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependencies
key overrides the dependencies
key above, which contains json-formatter-js
. You have a duplicate JSON key here.
JSONFormatter
in build by default