Skip to content

Include JSONFormatter in bundle #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Include JSONFormatter in bundle #25

merged 1 commit into from
Oct 21, 2017

Conversation

mhamann
Copy link
Contributor

@mhamann mhamann commented Oct 17, 2017

  • Converted build to use webpack
  • Upgraded babel version
  • Included JSONFormatter in build by default
  • Removed bower deps in favor of npm

@mohsen1
Copy link
Owner

mohsen1 commented Oct 17, 2017

very nice! I'll merge it tonight

@mhamann
Copy link
Contributor Author

mhamann commented Oct 20, 2017

@mohsen1 and updates on merging this and publishing a new version to npm?

@mohsen1 mohsen1 merged commit 1f87948 into mohsen1:master Oct 21, 2017
@mohsen1
Copy link
Owner

mohsen1 commented Oct 21, 2017

Hey @mhamann this is great but we need to make sure it works end-to-end
I couldn't make a build and confirm this is working and don't have enough time to dig into it.

I would like to move away from bower and gulp and instead build it with webpack and test it with Jest

Can you look into it?

Thanks!

@mhamann
Copy link
Contributor Author

mhamann commented Oct 22, 2017

@mohsen1 yeah, i can try to find some time to work on that. (cc: @chrisdudley - maybe someone from your team could collab w/ me on this)

I see the PR was reverted. Did something break?

I did run some manual tests to ensure this worked and solved the issue--and it did. But certainly could break people if they were depending on the bower side of things.

This probably deserves a 2.0.0 version bump.

@mohsen1
Copy link
Owner

mohsen1 commented Oct 22, 2017

The bower dependencies were still in the demo app. What I wish I could do is to have webpack dev server for demo and webpack for building the js/css assets

@mhamann
Copy link
Contributor Author

mhamann commented Oct 22, 2017

Gotcha. Webpack dev server shouldn't be a problem.

@mitar
Copy link
Contributor

mitar commented Oct 25, 2017

I tried the version at this commit (1f87948) and I can use it in my code with npm + browserify with:

import JSONSchemaView from 'json-schema-view-js';

On the current master branch (with commit reverted) I cannot because it does not find ./helpers.js during browserify bundling.

One thing I had to add was json-formatter-js dependency, which was not automatically installed.

"webpack": "^3.8.1",
"webpack-stream": "^4.0.0"
},
"dependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependencies key overrides the dependencies key above, which contains json-formatter-js. You have a duplicate JSON key here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants