Additional checkers

[abougouffa]

First, I would like to thank you for this collection!

I've been using flymake-collection to define some checkers in my config for tools that I use regularly. And I thought I should contribute them back!

This PR include checkers for:

• bandit
• codespell
• pyre
• clang-tidy
• nasm

I've tried to add the install commands and some tests, but I'm kind of trying blindly because I didn't manage to run the Docker used to run tests!

Edit

A little bug fix slipped into one of the commits, the setup hook for Elisp was wrongly set to elisp-mode instead of emacs-lisp-mode.

[mohkale]

Thanks for contributing and also thanks for adding tests 🥳. Could you just update the group for the clang-tidy checker customs. Then this should be good to merge :-).

[abougouffa]

Thanks for the feedback, I've done the changes.

Thanks again for your responsiveness!

[mohkale]

LGTM :-). Let's merge.

[mohkale]

Could you fix the build failures please? The nasm tests are failing. Ruff is failing as well but I think you just need to merge in the release branch since I fixed that while back. The checkdoc build is failing on the snapshot branch so fine to ignore that. The others should ideally pass.

[abougouffa]

Hi again @mohkale ,

I've pushed a fix to pass the test. It seems like the NASM version included in the test container is a bit older than mine, hence the difference in the messages.

It should be fixed now!

[abougouffa]

@mohkale I've fixed in issue in clang-tidy, it should pass the linter now!

[abougouffa]

Reverted (require 'subr)

[mohkale]

I've seen this failure before but can never remember how to fix it. When I get some free time I'll take a look. If you'd prefer please continue trying to debug. You should be able to run the linter yourself with make lint 🤔.

[abougouffa]

Hi again @mohkale

I've tried the linter on the current branch and it comes clean!

$ make lint
[compile] src/checkers/flymake-collection-clang-tidy.el
[compile] src/checkers/flymake-collection-less.el
[compile] src/checkers/flymake-collection-luacheck.el
[compile] src/checkers/flymake-collection-hlint.el
[compile] src/checkers/flymake-collection-statix.el
[compile] src/checkers/flymake-collection-pylint.el
[compile] src/checkers/flymake-collection-mypy.el
[compile] src/checkers/flymake-collection-flake8.el
[compile] src/checkers/flymake-collection-codespell.el
[compile] src/checkers/flymake-collection-shellcheck.el
[compile] src/checkers/flymake-collection-markdownlint.el
[compile] src/checkers/flymake-collection-lua.el
[compile] src/checkers/flymake-collection-bandit.el
[compile] src/checkers/flymake-collection-nasm.el
[compile] src/checkers/flymake-collection-sql-lint.el
[compile] src/checkers/flymake-collection-xmllint.el
[checkdoc] src/flymake-collection-define.el
[checkdoc] src/flymake-collection.el
[checkdoc] src/flymake-collection-commands.el
[checkdoc] src/flymake-collection-hook.el
[checkdoc] src/checkers/flymake-collection-jq.el
[checkdoc] src/checkers/flymake-collection-yamllint.el
[checkdoc] src/checkers/flymake-collection-pyre.el
[checkdoc] src/checkers/flymake-collection-gcc.el
[checkdoc] src/checkers/flymake-collection-kube-linter.el
[checkdoc] src/checkers/flymake-collection-clang.el
[checkdoc] src/checkers/flymake-collection-pycodestyle.el
[checkdoc] src/checkers/flymake-collection-html-tidy.el
[checkdoc] src/checkers/flymake-collection-ruff.el
[checkdoc] src/checkers/flymake-collection-jsonlint.el
[checkdoc] src/checkers/flymake-collection-rubocop.el
[checkdoc] src/checkers/flymake-collection-sqlint.el
[checkdoc] src/checkers/flymake-collection-vale.el
[checkdoc] src/checkers/flymake-collection-awk-gawk.el
[checkdoc] src/checkers/flymake-collection-eslint.el
[checkdoc] src/checkers/flymake-collection-proselint.el
[checkdoc] src/checkers/flymake-collection-clang-tidy.el
[checkdoc] src/checkers/flymake-collection-less.el
[checkdoc] src/checkers/flymake-collection-luacheck.el
[checkdoc] src/checkers/flymake-collection-hlint.el
[checkdoc] src/checkers/flymake-collection-statix.el
[checkdoc] src/checkers/flymake-collection-pylint.el
[checkdoc] src/checkers/flymake-collection-mypy.el
[checkdoc] src/checkers/flymake-collection-flake8.el
[checkdoc] src/checkers/flymake-collection-codespell.el
[checkdoc] src/checkers/flymake-collection-shellcheck.el
[checkdoc] src/checkers/flymake-collection-markdownlint.el
[checkdoc] src/checkers/flymake-collection-lua.el
[checkdoc] src/checkers/flymake-collection-bandit.el
[checkdoc] src/checkers/flymake-collection-nasm.el
[checkdoc] src/checkers/flymake-collection-sql-lint.el
[checkdoc] src/checkers/flymake-collection-xmllint.el

[abougouffa]

ping @mohkale !

[mohkale]

Hi, sorry. Didn't get a chance to check this this weekend. I'll take a look when I have some free time.

[mohkale]

FYI Tried taking a look at this, annoyingly some regressions in pylint and the rx interface is causing the build on the master branch to fail which is rippling into this PR. It requires some refactoring so when I have some more time I'll address the failures but won't be able to merge this PR until afterwards (just to avoid compounding issues 😞).

[mohkale]

@abougouffa Took me a while to reprioritise this but i've fixed the build failures on the master branch. You're PR is currently failing linting on Emacs 28.1. I'd suggest double checking by running make lint from a container with Emacs 28.1 installed.

[abougouffa]

Hi @mohkale

Thank you for the feedback,

I see the issue now, I will fix it ASAP!

Thanks again!

[mohkale]

Hiya, there still seems to be some issues with the build. Please take a look when you get a chance. I've also noticed for some reason CI didn't run automatically when you commit, I've pushed something that should fix that but I'll keep monitoring to see if the issue persists 🤔.

[abougouffa]

Hi @mohkale

Thank you for the reminder.

I've pushed a fix for the detected issue.

I've run the test and lint actions in my fork and I see that it is passing now.

https://github.com/abougouffa/flymake-collection/actions

Thanks again!

[mohkale]

LGTM :-). Thanks for contributing.