Skip to content

Update PendingEveryNDaysRepeat.php #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update PendingEveryNDaysRepeat.php #13

wants to merge 1 commit into from

Conversation

fuzzyjared
Copy link

The endsAfter method is indirectly updating the $this->start_at value due to object reference instead of creating its own CarbonInterface object.

@fuzzyjared
Update PendingEveryNDaysRepeat.php
22dc889 
$this->end_at is indirectly updating $this->start_at due to object reference.
@EriBloo
Copy link
Contributor

EriBloo commented Apr 4, 2024

Hi.
This is not true. There is toImmutable() called on start_at so any modifications return new object. This PR is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzyjared @EriBloo