Fix incompatibility with JDK, code inconsistencies and upgrade to C++17 #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault enum memory representation
…Lib namespace to prevent global scope pollution
…t's fully support starting with Windows 8
…ShellLinkPath to use std::optional and std::filesystem::path
…IWinToastHandler into its own header Refactor out Windows specific includes into Platform.h, refactor out IWinToastHandler into its own header
…ADED to avoid JDK incompatibility issues due to JDK-8353140. Add nodiscard attributes, cleanup code further
|
Gonna fix the last remaining issues with this later today hopefully :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this is a draft, but i started working on a 2.0.0 of this library.
Sadly due to the JDK bug, this has to be break the current ABI, so a major version bump is required.
Any suggestions/requests are appreciated, as of right now the progress looks like this:
I'll try to finish this as soon as possible :)