Fix/audit correctness bugs#1045
Merged
Merged
Conversation
store.GetServices("", "*") built the key pattern
"resources:v1:Service::*" (empty namespace segment) which matches no
real key. Ingress-controller external IPs were never collected, so
external traffic was misclassified as local in traffic accounting.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
GetLogger/CreateLogger accessed the logger map without synchronization and lastWatchCheckStart was written from the CRD debounce timer goroutine concurrently with direct callers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
startCollector returned without a channel reader on non-linux, so the first CpuUsageGlobal()/RamUsageGlobal() call blocked forever. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.