-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big trash refactor #16600
Big trash refactor #16600
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16600 +/- ##
============================================
- Coverage 21.57% 21.55% -0.03%
- Complexity 10599 10600 +1
============================================
Files 561 561
Lines 32095 32107 +12
============================================
- Hits 6926 6922 -4
- Misses 25169 25185 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
The only thing that's missing is an update script to add the new menu during upgrade.
@GulomovCreative do you think you’ll have time to get the update script for adding the new menu during an upgrade done? |
@rthrash Can I see some examples? I don't know how it works |
@GulomovCreative here are current upgrade scripts https://github.com/modxcms/revolution/blob/3.x/setup/includes/upgrades/mysql/3.1.0-pl.php you can check those or older ones for samples |
Added the upgrade script & adjusted the lexicon for context menu in the tree |
6291907
to
b439be0
Compare
@opengeek rebased to 3.x |
b439be0
to
1820b1c
Compare
What does it do?
Why is it needed?
There are many errors when deleting/restoring/purging resources
How to test
Related issue(s)/PR(s)
#14190