Fix incorrect return type #16567
Merged
Fix incorrect return type #16567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the union of return types in documentation, so it's understood by IDEs.
Mark-H
approved these changes
May 2, 2024
Ibochkarev
approved these changes
May 3, 2024
theboxer
approved these changes
May 16, 2024
Ibochkarev
added
the
pr/ready-for-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the union of return types in documentation, so it's understood by IDEs.
What does it do?
IDEs like PhpStorm saw this method as returning only
null. This change gets them to seenullormixedas the return types.Why is it needed?
Described above.
How to test
Use this method in an IDE; confirm it doesn't have any red lines under the usages.
Related issue(s)/PR(s)
N/A