Add missing system setting for profile photo media source #16515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a long-missing setting for specifying user's profile photo media source
Mark-H
approved these changes
Feb 10, 2024
smg6511
added
pr/ready-for-merging
opengeek
pushed a commit
that referenced
this pull request
Mar 25, 2024
### What does it do? Adds a long-missing setting for specifying user's profile photo media source. Also, moves up (and tweaks) the associated Lexicon entries. ### Why is it needed? The logic has been present in the backend to specify a Media Source other that the default for user profile photos since they were introduced nearly 10 years ago. However, the system setting was never added to the build, making it virtually unknown that this functionality existed. ### How to test Run `_build/transport.core.php` to install the new setting. Then search for `photo_profile_source` in the system settings, change its value, and verify that the Media Source shown in the Media Browser (when editing/adding a user profile photo) matches that which you specified in the setting. ### Related issue(s)/PR(s) Resolves #16510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a long-missing setting for specifying user's profile photo media source. Also, moves up (and tweaks) the associated Lexicon entries.
Why is it needed?
The logic has been present in the backend to specify a Media Source other that the default for user profile photos since they were introduced nearly 10 years ago. However, the system setting was never added to the build, making it virtually unknown that this functionality existed.
How to test
Run
_build/transport.core.phpto install the new setting. Then search forphoto_profile_sourcein the system settings, change its value, and verify that the Media Source shown in the Media Browser (when editing/adding a user profile photo) matches that which you specified in the setting.Related issue(s)/PR(s)
Resolves #16510