Fix warnings for unset params

Adds new utility function to evaluate boolean-type values, which ensures only set params are accessed; applies this function to the two vars in the textarea input opts config file that were throwing php warnings. Note that the new function will be applicable to other config files.

core/src/Revolution/Processors/Element/TemplateVar/Configs/mgr/inputproperties/textarea.php

@@ -16,8 +16,8 @@
 # Set values
 $defaultHeight = 140;
 $inputHeight = !empty($params['inputHeight']) ? $params['inputHeight'] : $defaultHeight ;
-$textareaGrow = $params['textareaGrow'] === 'true' || $params['textareaGrow'] == 1 ? 'true' : 'false' ;
-$textareaResizable = $params['textareaResizable'] === 'true' || $params['textareaResizable'] == 1 ? 'true' : 'false' ;
+$textareaGrow = $this->modx->paramValueIsTrue($params, 'textareaGrow', true);
+$textareaResizable = $this->modx->paramValueIsTrue($params, 'textareaResizable', true);
 
 # Set help descriptions
 $descKeys = [

core/src/Revolution/modX.php

@@ -394,6 +394,23 @@ public static function toQueryString(array $parameters = [], $numPrefix = '', $a
         return http_build_query($parameters, $numPrefix, $argSeparator);
     }
 
+    /**
+     * Evaluate boolean-like parameter value and return it as an actual boolean or as a string; a string may be
+     * needed/preferred when building code blocks (e.g., javascript) via php strings (nowdoc/heredoc ones in particular).
+     *
+     * @param array $params An associative or numeric-indexed array of parameters
+     * @param string|int $key The array key to evaluate
+     * @param bool $returnBoolAsString Whether to return the string representation ('true' or 'false') of the boolean value
+     * @return string|bool
+     */
+    public function paramValueIsTrue(array $params, $key, bool $returnBoolAsString = false)
+    {
+        if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1])) {
+            return $returnBoolAsString ? 'true' : true ;
+        }
+        return $returnBoolAsString ? 'false' : false ;
+    }
+
     /**
      * Create, retrieve, or update specific modX instances.
      *