Skip to content

Tools sparkle2 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Tools sparkle2 #54

wants to merge 6 commits into from

Conversation

Mark-H
Copy link
Collaborator

@Mark-H Mark-H commented Apr 28, 2025 •
edited
Loading

#48

Mark-H added 2 commits April 28, 2025 19:29
@Mark-H
chore(icons): move sparkle animation styles from JS to CSS
8b578ee
@Mark-H
feat(ui): improve button order and styling
da7529c 
- Updated button append order in the generateButton component to align with desired layout.
- Enhanced CSS styles for buttons and containers to ensure consistent appearance, added accessibility outlines, and improved responsive handling.
@Mark-H
Copy link
Collaborator Author

Mark-H commented Apr 28, 2025

Scherm­afbeelding 2025-04-28 om 19 57 11

@Mark-H Mark-H marked this pull request as ready for review April 28, 2025 17:57
@Mark-H Mark-H requested review from theboxer and rthrash April 28, 2025 17:57
@theboxer
Copy link
Member

@Mark-H I like the pagination, but I think it's way more dominant than the spark button, maybe it should be just an outline?

@rthrash
Copy link
Member

rthrash commented May 13, 2025

@Mark-H some awesome work on this. Let's try it without button outlines on the pagination also. Something just feels off with it outlined, but the main AI button not, and too much going on when both are outlined. I'll attached some tweaks to streamline things and purge some probably-no-longer-needed CSS rules simplify any future styling updates so they won't have to fight iterations of CSS overrides.

@rthrash
Copy link
Member

rthrash commented May 13, 2025

Here's how it looks with the attached tweaks:
Screenshot 2025-05-13 at 4 30 17 PM

The changes are on .generate (~line 1022), .history-wrapper (~1071), and its prev/next buttons (~1083).

Screenshot 2025-05-13 at 4 39 00 PM Screenshot 2025-05-13 at 4 38 40 PM

CSS file attached (as a Zip, b/c can't upload CSS here): modai.css.zip

rthrash
rthrash requested changes May 13, 2025
View reviewed changes
Copy link
Member

@rthrash rthrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my last comment and attached files on the PR. Sorry for not doing that all here!

@Mark-H
Copy link
Collaborator Author

Mark-H commented May 13, 2025

That works! Added to PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rthrash rthrash rthrash requested changes

@theboxer theboxer Awaiting requested review from theboxer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mark-H @theboxer @rthrash