Cached and nested snippets not working in EVO 1.2

[vinelandit]

a) Snippets called in [!snippetName!] format are not parsed, and just return the literal [[snippetName]] (replacing the [!!] brackets with [[]])

b) Nested snippets in alternating cached/uncached format, i.e. [!outerSnippet? &param='[[innerSnippet]]'!] are not parsed, and nested snippets using uncached format throughout throw a MySQL error.

(Backticks replaced with quotes in sample calls to avoid being marked up)

Example call:

[[Ditto? &documents='[[getVal? &docid='1' &field='featurePanel1']]' &tpl='homePanel' &extenders='summary' &truncLen='180' &truncOffset='90' ]]

Example error (similar error occurs when the inner snippet is called in uncached format, and the whole call unparsed and returned literally when the outer snippet is in uncached format):

« MODX Parse Error »
Execution of a query to the database failed - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '[[getVal?&docid=) AND sc.published=1 AND sc.deleted=0) AND (sc.privateweb=0) GRO' at line 1
SQL > SELECT DISTINCT sc.id FROM 'ajfadmin_modx'.'modx_site_content' sc LEFT JOIN 'ajfadmin_modx'.'modx_document_groups' dg on dg.document = sc.id WHERE (sc.id IN ([[getVal?&docid=) AND sc.published=1 AND sc.deleted=0) AND (sc.privateweb=0) GROUP BY sc.id
Error information
Current Snippet Ditto ... etc.

[modxuser]

I am not a back-end Dev, but the question arises - do your custom snippets still use deprecated MYSQL functions, as 1.2 supports MYSQLI

I have just checked my sites that have nested snippets, all of them work as expected. An example: I use "IF" in combination with Ditoo for IDs and other conditionals - all work perfectly OK

[vinelandit]

Hi modxuser, thanks for your reply. No, the custom snippets in question don't make any database calls.

Can you confirm that switching your cached [[Ditto? ... ]] call for a cached [!Ditto? ... !] call still works?

[Deesen]

[!Ditto!] still works for me testing the demo-page with blog, see screenshots. But inside ditto-tpl there is a uncached [!Jot!] which will be outputted for me like

[modxuser]

I have since updated my nested "IF" calls with the new built-in modifiers, but changing the Ditto snippet call from cached to uncached doesn't make any difference, it all still works.

[yama]

@vinelandit Thank you for your information, I will fix it later

[Dmi3yy]

http://take.ms/oPgO7

This all ok
http://take.ms/pi8zW

But if change to [[Ditto not work (((

need normal work:
[[ [[
[! [!
[[ [!
[! [[

[yama]

&year=`[[date_filter? &type=`year`]]`

This call will not work. Because it can not recognize the value nest. As with programming with PHP, you need to use different quotes.

&year="[[date_filter? &type='year']]"

&year='[[date_filter? &type="year"]]'

&year=`[[date_filter? &type="year"]]`

For example, write like these.
By changing the specification like this, it is now possible to include characters such as " = ? & ` " in the value.
But it may be improved further. I will think about it.

[Dmi3yy]

But all this work on 1.1 Its work from 1.0.9 or 1.0.8 And this big problem for update. Need or fixed or write what need do. Отправлено с iPhone

…

13 дек. 2016 г., в 23:35, yamamoto ***@***.***> написал(а): &year=`[[date_filter? &type=`year`]]` This call will not work. Because it can not recognize the value nest. As with programming with PHP, you need to use different quotes. &year="[[date_filter? &type='year']]" For example, write like this. By changing the specification like this, it is now possible to include characters such as " = ? & ` " in the value. But it may be improved further. I will think about it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[yama]

ok, I will fix it later