feat(css): add bundleAllCSS option to control CSS asset inclusion in exposed modules #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gioboa please review. |
pcfreak30
force-pushed
the
fix/337
branch
2 times, most recently
from
b75d5a6 to
fc82810
Compare
gioboa
reviewed
Oct 29, 2025
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Nice, can you add the documentation for this prop in the README please?
gioboa
reviewed
Oct 29, 2025
Contributor
Author
done |
gioboa
reviewed
Oct 29, 2025
…exposed modules * Added `bundleAllCSS` option to `ModuleFederationOptions` and `NormalizedModuleFederationOptions` interfaces * Updated manifest plugin to conditionally include all CSS assets in exports based on `bundleAllCSS` setting * Added tests to verify default and explicit `bundleAllCSS` option behavior * Updated `cssModuleHelpers.test.ts` to import `normalizeModuleFederationOptions` and mock `bundleAllCSS` option * Added new test suite in `cssModuleHelpers.test.ts` to validate `bundleAllCSS` option handling * Updated `normalizeModuleFederationOption.test.ts` to include `bundleAllCSS`, `getPublicPath`, and `publicPath` in expected default values
Contributor
Author
|
@gioboa tests are passing now. |
gioboa
approved these changes
Oct 29, 2025
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Thanks for this @pcfreak30 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundleAllCSSoption toModuleFederationOptionsandNormalizedModuleFederationOptionsinterfacesbundleAllCSSsettingbundleAllCSSoption behaviorcssModuleHelpers.test.tsto importnormalizeModuleFederationOptionsand mockbundleAllCSSoptioncssModuleHelpers.test.tsto validatebundleAllCSSoption handlingnormalizeModuleFederationOption.test.tsto includebundleAllCSS,getPublicPath, andpublicPathin expected default valuesClose #337