fix: sort all shared items to create deterministic builds when hashes are used #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using hashes for the remoteEntry file in the plugin, the hashes are sometimes different because the order of the
usedSharedobject is different. This causes builds to be non-deterministic when in fact nothing has changed. For example:During 2 builds for the exact same source, the remoteEntry and hostInit may have different hashes because the remoteEntry may differ in the ordering of the
usedSharedkeys:It's a bit hard to reproduce in a toy app since I think the cause is the async hooks across a large number of files in our application, but this simple one-liner ought to fix it.