Feat base url he110 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He110te4m
force-pushed
the
feat-base-url-he110
branch
from
b1e69ff
to
0c3f157
Compare
|
Sorry, there may be something wrong with this code. |
… of the external library import
He110te4m
force-pushed
the
feat-base-url-he110
branch
from
0c3f157
to
de344fd
Compare
|
This change now completely overrides my usage scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #14
The problem has two parts:
remoteEntry.jsondoes not match. The reason is that this line of code splices the address directly, but Vite's base doesn't affect the path in dist, so the urls don't match.baseUrlis not supported when external imports are replaced in the plugin. The reason is that the replacement rule only matches/@id/${libraryName}. WhenbaseUrlis configured, the import path is:/${baseUrl}/@id/${libraryName}. So we need to modify the rule to match the quotes directly.