Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 4a13aa9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 48 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Sep 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With version-first sharing, an unavailable remote manifest currently rejects
loadShare()even when the host or another remote can provide the shared dependency. Move remote resolution into the existingbeforeLoadShareerror boundary. When the hook returns nothing, skip the unavailable remote for that attempt; when it supplies a container, initialize it through a transient module. Because no placeholder manifest is cached, later calls can retry the remote after it recovers.Add regression tests covering repeated loads while the manifest is unavailable, a healthy remote, recovery on a later load, and a hook-provided fallback container. Include a patch changeset for
@module-federation/runtime-core.Validation
corepack pnpm exec turbo run build --filter=@module-federation/runtime-core— passed.corepack pnpm --filter @module-federation/runtime-core exec rstest run --include "**/*.spec.ts"— 128 tests passed.corepack pnpm exec prettier --check packages/runtime-core/src/shared/index.ts packages/runtime-core/__tests__/shared-diagnostics.spec.ts .changeset/fuzzy-remotes-recover.md— passed.git diff --cached --check— passed.Local check limitations
corepack pnpm install --frozen-lockfilefailed in the unrelatedchrome-devtoolspostinstall because WSL is unavailable on this Windows host.corepack pnpm install --frozen-lockfile --ignore-scriptscompleted.rstest -ucommand matches no tests on Windows due to its glob. The full suite passed with the explicit include pattern above.node tools/scripts/check-format-changed.mjscompared against a stale localmainand reported 53 unrelated files; the three PR files pass the targeted check.corepack pnpm exec changeset status --verbosecould not run because the Windows build of the local release-plan package references a missing./apply-links.ts. The changeset was parsed separately and contains one patch release for runtime-core.Risk
For a manifest failure, plugins observing both
afterResolveandbeforeLoadSharereceive an error event at each lifecycle stage. A hook-provided container is initialized through a transient module so the manifest remains retryable.