Repository navigation
test(ssr): add update contracts and artifact regression baseline - #5048
Conversation
|
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/playground
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/rstest
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c213105c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert.equal(result.dynamic.savedHandler, 'v1'); | ||
| assert.equal(result.dynamic.reimport, 'v1'); | ||
| assert.equal(result.dynamic.mappingContainsDynamic, false); | ||
| assert.equal(result.rebuild.dynamicResult, 'v2'); |
There was a problem hiding this comment.
When the host is rebuilt after remote changes from v1 to v2, the emitted host still contains its original v1 startup configuration. The fixture records this scenario as result.rebuild.staticResult, but this block checks only dynamicResult; because dynamic was registered solely at runtime and is absent from the startup configuration, that assertion cannot detect startup configuration overwriting an accepted update for an existing remote. Such a regression would therefore pass the baseline despite violating the documented rebuild contract, so assert that staticResult remains v2 as well.
Useful? React with 👍 / 👎.
1 participant
Description
Adds the R0 SSR update contract and portable real-artifact regression baseline on top of
feat/mf-ssr-clear-cache. The contract defines persistent MF host ownership, disposable bundler bindings, revision/publication semantics, and Modern request admission. No production runtime behavior changes.Four isolated Rspack fixtures cover static parent invalidation, concatenation, dynamic retained references, adapter rebinding, and shared identity. An opt-in Modern HTTP fixture verifies resource publication without changing the server/PID/port. Seven known failures execute as TODOs; strict mode makes them blocking, and unexpected passes require removing the TODO.
Validation: runtime-tools dependency build passed (6 tasks); local Rspack + Modern baseline: 5 passed / 7 TODO; installed canary: 4 passed / 7 TODO / 1 explicit Modern skip; existing clearCache Jest tests: 6 passed. Changed-file format and syntax checks passed. Modern SSR CI built 44 packages but failed the existing
remove-remote-cache.cy.js:51runtime-capture assertion; the shared-cache spec passed. Full-repo formatting failed on 683 generated/existing files. Exact commands, environment recovery, and untested production boundaries are recorded intools/ssr-cache/VALIDATION.md.Related Issue
No separate issue linked. Implements R0 of the agreed Modern/MF SSR cache RFC; R1–R6 remain open.
Types of changes
Checklist