Skip to content

Conversation

@ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented Oct 17, 2025

Summary

  • add a router-specific e2e runner that waits for ports, runs tests, and tears down processes
  • swap the GitHub Actions router workflow to call the script instead of the inline shell chain
  • drop the unused CI wait override to keep behaviour deterministic

Testing

  • gh pr checks --watch

@netlify
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 45d61a1
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/68f1b503bcec810008465522
😎 Deploy Preview https://deploy-preview-4137--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: 45d61a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy changed the title fix: ensure router e2e cleans all ports fix: stabilize router e2e workflow Oct 17, 2025
@ScriptedAlchemy
Copy link
Member Author

@codex review pr

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@ScriptedAlchemy ScriptedAlchemy merged commit 98b78aa into main Oct 17, 2025
19 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the chore/ci-router-kill-remotes branch October 17, 2025 03:41
@danpeen danpeen mentioned this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants