fix(enhanced): Add fallback parsing for container module exposes #4034

vinicius-at-webflow · 2025-09-01T19:34:58Z

Description

The _handleContainerModule method from packages/manifest/src/ModuleHandler.ts calls split(' ') on the module's identifier which breaks if the path or expose key contain spaces or other special characters.

Here's a an example of a problematic identifier (see the import path for the Button expose):

container entry (default) [["./Button",{"import":["./src/path with spaces/Button.tsx"],"name": "__federation_expose_Button"}]]

Related Issue

#2684

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

I have added tests to cover my changes.
All new and existing tests passed.
I have updated the documentation.

changeset-bot · 2025-09-01T19:35:02Z

⚠️ No Changeset found

Latest commit: 754c028

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2025-09-01T19:35:06Z

✅ Deploy Preview for module-federation-docs ready!

Name	Link
🔨 Latest commit	`94d354c`
🔍 Latest deploy log	https://app.netlify.com/projects/module-federation-docs/deploys/68c713d6f16b300008dca037
😎 Deploy Preview	https://deploy-preview-4034--module-federation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

vinicius-at-webflow · 2025-09-01T19:36:38Z

Opened previous PR with main as source branch 😓. Sorry for the inconvenience!

vinicius-at-webflow · 2025-09-01T19:37:20Z

packages/manifest/src/ModuleHandler.ts

+    let entries: Array<
+      [exposeKey: string, { import: string[]; name?: string }]
+    > = [];
+
+    try {
+      // Prefer parsing exposes from stats first
+      entries = JSON.parse(data[3]);
+    } catch {
+      // If that fails, fallback to the original options
+      const exposes = this._options.exposes;
+
+      if (!exposes || typeof exposes !== 'object') {
+        return;
+      }
+
+      entries = Object.entries(exposes);
+    }
+
+    entries.forEach(([prefixedName, file]) => {


I'm opting to maintain the current JSON parsing logic and wrap it in a try catch block. There are probably good reason why it was implemented this way in the first place, but I lack the context, and I rather be as safe/backwards compatible as possible. If it fails the introduced logic just attempts to recover exposes from another source.

@2heal1 @ScriptedAlchemy As you mentioned in the issue, there are probably better ways of solving this, but again, I lack the context to propose a long-term solution. You mentioned a short-term solution, but since the issue was closed, I figured it wouldn't hurt proposing this patch 😅.

Also note I'm open to contribute and implement this in a different way if I can get some high level guidance (Just a couple of quick notes would be really helpful).

vinicius-at-webflow · 2025-09-01T19:37:35Z

packages/enhanced/test/configCases/build-version/package-json-version/webpack.config.js

      library: { type: 'commonjs-module' },
      filename: 'remoteEntry.js',
      exposes: {
+        './a test module': './test.js',


This does break without the patch. Would this be enough test coverage?

But this is not expected expose key, will this issue only happen in this scene ?

@2heal1 Oh, you're absolutely right. But it does break if the spaces are present on the path, say:

{ exposes: { './test': './path with spaces/test.js' } }

I just wanted to modify the test as little as possible, but I can tweak it to represent an actual real scenario!

vinicius-at-webflow · 2025-09-01T19:38:26Z

packages/manifest/src/ModuleHandler.ts

+      // If that fails, fallback to the original options
+      const exposes = this._options.exposes;
+
+      if (!exposes || typeof exposes !== 'object') {


#4027 (comment)

From my investigations this.options.exposes in ModuleHandler is always parsed into

interface ExposesObject { [k: string]: ExposesConfig; } interface ExposesConfig { import: ExposesItem | ExposesItems; name?: string; }

by ContainerManager.containerPluginExposesOptions. But due to how everything is currently typed, TS thinks this could be the broader "unparsed" Exposes shape.

type Exposes = (ExposesItem | ExposesObject)[] | ExposesObject;

This is how it looks like, for both enhanced/ModuleFederationPlugin and rspack/ModuleFederationPlugin

Now, we could maintain this 100% decoupled and idempotently "re-parse" the entries ModuleHandler to ensure the type safety, but I would wait for a review first before increasing the complexity here. cc @ScriptedAlchemy @2heal1

2heal1 · 2025-09-05T03:04:25Z

Does the issue only happen in legacy version ? I want to know which version , if old enough, maybe no need to compate it .

Can you provide a minimal reproduce repo ? So i can get more info .

vinicius-at-webflow · 2025-09-05T13:45:50Z

@2heal1 No, it happens on any version, even the latest. Its probably under the radar (although there is an issue open #2684) because it is very unusual to have spaces in paths in "conventional" codebases 😆.

But in our use case of Module Federation, we have no control over what the project folder structure looks like (and in fact we have run into the issue more than once), so this is why I'm proposing this fix!

Here's the repro, just npm install; npm run build:

https://github.com/vinicius-at-webflow/mf-path-issues

You should see

[webpack-cli] HookWebpackError: Unterminated string in JSON at position 120
  SyntaxError: Unterminated string in JSON at position 120
    at JSON.parse (<anonymous>)
    at ModuleHandler._handleContainerModule

because of "./test-2": "./src/path with spaces/test-2.js",

vinicius-at-webflow · 2025-09-05T13:49:38Z

I can probably add an integration test using this repo I sent you, to avoid any confusion around what this is fixing, exactly, so I guess a test would make everything more clear.

…ated edge case test

vinicius-at-webflow · 2025-09-06T17:53:14Z

@2heal1 I added a dedicated test case to validate the fix. If you uncomment you should see the same

Unterminated string in JSON at position 31; stack = HookWebpackError: Unterminated string in JSON at position 31
    at JSON.parse (<anonymous>)
    at ModuleHandler._handleContainerModule

as the user reports in the issue, as well as in the minimal repro I shared with you

vinicius-at-webflow · 2025-09-11T18:41:32Z

@2heal1 bump

ScriptedAlchemy · 2025-09-14T19:13:59Z

@codex review

chatgpt-codex-connector · 2025-09-14T19:19:31Z

Codex Review: Didn't find any major issues. Hooray!

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

vinicius-at-webflow · 2025-09-19T16:25:54Z

@2heal1 @ScriptedAlchemy have you had a chance to take a look at the repo I've prepared with the reproduction of the issue?

ScriptedAlchemy · 2025-09-19T19:54:19Z

Merging to branch under our control to see if theres better solution here to adjust pr. Will open pr again after quick investigation

…) (#4083) Co-authored-by: Vinicius Rocha <vinicius.rocha@webflow.com>

Integrate latest changes from origin/main: - chore(deps-dev): bump publint from 0.2.12 to 0.3.13 (#4109) - chore(deps): bump @changesets/get-dependents-graph from 2.1.2 to 2.1.3 (#4110) - fix enhanced type tests (#4113) - fix(enhanced): Add fallback parsing for container module exposes (#4034) (#4083) Resolved pnpm-lock.yaml conflict by regenerating the lockfile. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

vinicius-at-webflow added 3 commits August 28, 2025 18:22

fix(enhanced): add fallback parsing for container module exposes

aef90ed

fix(enhanced): add fallback parsing for container module exposes

68ebd01

Merge branch 'main' into main

2955c59

github-actions bot added the change: fix label Sep 1, 2025

vinicius-at-webflow commented Sep 1, 2025

View reviewed changes

vinicius-at-webflow marked this pull request as ready for review September 1, 2025 19:40

vinicius-at-webflow added 3 commits September 6, 2025 14:15

Merge branch 'main' into fix-handle-container-module

ba44e59

chore: remove changes to package-json-version tests and include dedic…

ef84efd

…ated edge case test

test: provide public path

b55085a

vinicius-at-webflow requested a review from 2heal1 September 6, 2025 17:54

Merge branch 'main' into fix-handle-container-module

94d354c

module-federation deleted a comment from chatgpt-codex-connector bot Sep 14, 2025

ScriptedAlchemy changed the base branch from main to container-json-parse September 19, 2025 19:52

Merge branch 'container-json-parse' into fix-handle-container-module

754c028

ScriptedAlchemy merged commit 1dc6591 into module-federation:container-json-parse Sep 19, 2025

ScriptedAlchemy added a commit that referenced this pull request Oct 1, 2025

fix(enhanced): Add fallback parsing for container module exposes (#4034…

7452cc0

…) (#4083) Co-authored-by: Vinicius Rocha <vinicius.rocha@webflow.com>

2heal1 mentioned this pull request Oct 10, 2025

Release v0.20.0 #4124

Merged

Uh oh!

fix(enhanced): Add fallback parsing for container module exposes #4034

fix(enhanced): Add fallback parsing for container module exposes #4034

Conversation

vinicius-at-webflow commented Sep 1, 2025

Description

Related Issue

Types of changes

Checklist

Uh oh!

changeset-bot bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

netlify bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for module-federation-docs ready!

Uh oh!

vinicius-at-webflow commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

2heal1 commented Sep 5, 2025

Uh oh!

vinicius-at-webflow commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinicius-at-webflow commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinicius-at-webflow commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinicius-at-webflow commented Sep 11, 2025

Uh oh!

ScriptedAlchemy commented Sep 14, 2025

Uh oh!

chatgpt-codex-connector bot commented Sep 14, 2025

Uh oh!

vinicius-at-webflow commented Sep 19, 2025

Uh oh!

ScriptedAlchemy commented Sep 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Sep 1, 2025 •

edited

Loading

netlify bot commented Sep 1, 2025 •

edited

Loading

vinicius-at-webflow commented Sep 1, 2025 •

edited

Loading

vinicius-at-webflow commented Sep 5, 2025 •

edited

Loading

vinicius-at-webflow commented Sep 5, 2025 •

edited

Loading

vinicius-at-webflow commented Sep 6, 2025 •

edited

Loading