fix(managers): correct manifest shared configuration

[2heal1]

Description

• correct manifest shared configuration
• enable noImplicitAny: true
• add sharedManager.normalizedOptions test

Related Issue

#3101

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the documentation.

[changeset-bot]

🦋 Changeset detected

Latest commit: c949342

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages

Name	Type
@module-federation/managers	Patch
@module-federation/dts-plugin	Patch
@module-federation/enhanced	Patch
@module-federation/manifest	Patch
@module-federation/rspack	Patch
@module-federation/modern-js	Patch
@module-federation/nextjs-mf	Patch
@module-federation/node	Patch
@module-federation/rsbuild-plugin	Patch
@module-federation/storybook-addon	Patch
@module-federation/modernjsapp	Patch
@module-federation/runtime	Patch
@module-federation/webpack-bundler-runtime	Patch
@module-federation/sdk	Patch
@module-federation/runtime-tools	Patch
@module-federation/third-party-dts-extractor	Patch
@module-federation/devtools	Patch
@module-federation/bridge-react	Patch
@module-federation/bridge-vue3	Patch
@module-federation/bridge-shared	Patch
@module-federation/bridge-react-webpack-plugin	Patch
@module-federation/retry-plugin	Patch
@module-federation/data-prefetch	Patch
@module-federation/error-codes	Patch
@module-federation/esbuild	Patch
@module-federation/utilities	Patch
website-new	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for module-federation-docs ready!

Name	Link
🔨 Latest commit	c949342
🔍 Latest deploy log	https://app.netlify.com/sites/module-federation-docs/deploys/673417557bcf2d00081cdd00
😎 Deploy Preview	https://deploy-preview-3219--module-federation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[squadronai]

Summary

The pull request focuses on resolving issues with the manifest shared configuration across several modules in the managers package of the module-federation/core project. The key changes include:

• Correcting the manifest shared configuration in the ContainerManager, PKGJsonManager, RemoteManager, and SharedManager classes.
• Enabling the noImplicitAny TypeScript compiler option to improve type safety and maintainability.
• Adding test cases for the sharedManager.normalizedOptions functionality to ensure the correctness of the shared configuration transformation.

These modifications aim to improve the reliability and maintainability of the affected modules by addressing configuration-related issues and enhancing the overall codebase quality.

File Summaries

File	Summary
packages/managers/src/ContainerManager.ts	The code changes in this pull request focus on correcting the manifest shared configuration, enabling the noImplicitAny TypeScript option, and adding a test for the sharedManager.normalizedOptions functionality. These modifications aim to improve the reliability and maintainability of the ContainerManager class in the module-federation/core project.
packages/managers/src/PKGJsonManager.ts	The code changes introduce a fix to the PKGJsonManager module by correcting the manifest shared configuration, enabling noImplicitAny: true, and adding a test for the sharedManager.normalizedOptions. The primary purpose of these modifications is to improve the reliability and maintainability of the module's functionality.
packages/managers/src/RemoteManager.ts	The code changes introduce a bug fix to the RemoteManager class. The primary modifications include correcting the dtsRemotes getter to handle the normalizedOptions property correctly, enabling the noImplicitAny TypeScript compiler option, and adding a test for the sharedManager.normalizedOptions functionality.
packages/managers/src/SharedManager.ts	The code changes introduce a fix to the SharedManager class in the managers package. The primary modifications include:

1. Correcting the manifest shared configuration by transforming the shared configuration options using the transformSharedConfig method.
2. Enabling the noImplicitAny TypeScript compiler option to improve type safety.
3. Adding a test case for the sharedManager.normalizedOptions functionality to ensure the correctness of the shared configuration transformation. |

[squadronai]

Incremental Review

Comments posted: 11

Configuration

Squadron Mode: essential

Commits Reviewed

168ce962b2940d15a8d6d415c6bb1b626c1cee5a...c949342e56a586abf4e8bbedf04e8f8082113f84

Files Reviewed

• packages/managers/src/ContainerManager.ts
• packages/managers/src/PKGJsonManager.ts
• packages/managers/src/RemoteManager.ts
• packages/managers/src/SharedManager.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

• .changeset/tough-yaks-lay.md
• packages/managers/tests/SharedManager.spec.ts
• packages/managers/tests/snapshots/SharedManager.spec.ts.snap
• packages/managers/tsconfig.json

[ScriptedAlchemy]

Amazing!