chore(dts-plugin): log error if the code is not ETIMEDOUT #3203
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
The pull request introduces an improvement to the error handling in the ModuleFederationDevServer class within the dts-plugin package. The key changes are:
- Added new error handling logic to log errors when the error code is not
ETIMEDOUT. Previously, the code only handled theETIMEDOUTcase. - This ensures that any other unexpected errors are properly surfaced and can be investigated further, improving the overall robustness of the codebase.
- The changes are accompanied by updated tests to cover the new error handling behavior.
- The documentation has also been updated to reflect these changes.
Overall, this pull request enhances the error handling capabilities of the ModuleFederationDevServer class, making the codebase more resilient and easier to debug in production environments.
File Summaries
| File | Summary |
|---|---|
| packages/dts-plugin/src/server/DevServer.ts | The code changes introduce a new error handling logic for the ModuleFederationDevServer class. If the error code received is not ETIMEDOUT, the code now logs the error to the console instead of just handling the ETIMEDOUT case. This ensures that any other unexpected errors are properly surfaced and can be investigated further. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
85990e2d231874c916270b685a13eca46ee983e0...065a23e8ddf4fca3f3455c6d29fc0e850571c590
Files Reviewed
- packages/dts-plugin/src/server/DevServer.ts
Description
log error if the code is not ETIMEDOUT
Related Issue
Types of changes
Checklist