Skip to content

Conversation

@tklever
Copy link
Contributor

@tklever tklever commented Nov 2, 2024

Add license metadata to bridge components to allow automated discovery of license information by software-supply chain tools. Without this metadata, these components appear as unlicensed to automated tools, which I don't believe is the intent.

I don't think these changes require a version bump, this is documenting what was already in place in the repo, they can go out with the next release.

Closes: #2977

@netlify
Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit cf98074
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67296425f2f9ab000828ac93
😎 Deploy Preview https://deploy-preview-3161--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2024

🦋 Changeset detected

Latest commit: cf98074

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/devtools Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/runtime Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tklever tklever marked this pull request as draft November 2, 2024 22:05
@tklever tklever marked this pull request as ready for review November 2, 2024 22:13
Add license metadata to bridge components to allow automated discovery of license information by software-supply chain tools. Without this metadata, these components appear as unlicensed to automated tools, which I don't believe is the intent.

Closes: module-federation#2977
# Conflicts:
#	packages/bridge/vue3-bridge/package.json
#	packages/chrome-devtools/package.json
@ScriptedAlchemy ScriptedAlchemy merged commit 3942740 into module-federation:main Nov 5, 2024
6 checks passed
@2heal1 2heal1 mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bridge-react-webpack-plugin is missing license

2 participants