Skip to content

fix: add optional check while accessing webpack internals #2968 #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 3 commits into from
Oct 29, 2024
Merged

fix: add optional check while accessing webpack internals #2968 #3120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83d8c77
fix: add optional check while accessing webpack internals
MadaraUchiha-314 Oct 26, 2024
a3d491d
chore: push changeset
MadaraUchiha-314 Oct 26, 2024
5c6ec74
Merge branch 'main' into fix-2968
MadaraUchiha-314 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-experts-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/node': patch
---

add optional check while accessing webpack internals
2 changes: 1 addition & 1 deletion packages/node/src/utils/hot-reload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export const performReload = async (
}
});
//@ts-ignore
__webpack_require__.federation.instance.moduleCache.clear();
__webpack_require__?.federation?.instance?.moduleCache?.clear();
Copy link
Contributor Author

@MadaraUchiha-314 MadaraUchiha-314 Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE to reviewers: The code above this already clears the module cache of all the registered remotes. This line assumes that the current execution context is within a federated remote built using federation + webpack, which might not be the case

helpers.global.resetFederationGlobalInfo();
globalThis.moduleGraphDirty = false;
globalThis.mfHashMap = {};
Expand Down
Loading