Skip to content

Conversation

@2heal1
Copy link
Member

@2heal1 2heal1 commented Oct 11, 2024

Description

limit engines range, incase local env is different from ci which can not easy to troubleshoot

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 4a5ea2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 4a5ea2c
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6708fb82b49f2a0008a9763c
😎 Deploy Preview https://deploy-preview-3066--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy
Copy link
Member

yes i encountered this, i use corepack locally to use the packageManager spec set. otherwise pnpm breaks the package resolution on TS i find. Good idea here!

@2heal1 2heal1 merged commit 7187626 into main Oct 14, 2024
@2heal1 2heal1 deleted the chore/engines-limit branch October 14, 2024 02:41
@2heal1 2heal1 mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants