-
-
Notifications
You must be signed in to change notification settings - Fork 374
fix(runtime): provide error message when remote entry init fails #2746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: dd758da The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3e0b37f to
e56faba
Compare
markmssd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this through? I just lost 2 hours investigating why a remote couldn't load until I found the id clash 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
The pull request provides an error message when the remote entry initialization fails. The changes are made in the packages/runtime/src/module/index.ts file, which adds error handling for the remote entry initialization process. If the 'init' method is not found in the remoteEntryExports, it logs an error message with troubleshooting steps.
The changes aim to improve the overall reliability and user experience of the module federation runtime by providing more informative error messages when issues arise during the remote entry initialization process.
File Summaries
| File | Summary |
|---|---|
| packages/runtime/src/module/index.ts | The code adds error handling for remote entry initialization. It checks if the 'init' method exists in remoteEntryExports and logs an error message with troubleshooting steps if it's undefined. |
Commits reviewed:
624ad4bf04a17319f9449cdb86a2193cc522aab5...0a94deae7ee9bd0acdedfa227fd764f27300fce1
Description
Provide error message if remoteEntry inner methods fail
Related Issue
#2737
Types of changes
Checklist