Skip to content

Conversation

@2heal1
Copy link
Member

@2heal1 2heal1 commented Jun 6, 2024

Description

when tag is loaded , don't modify attr . Otherwise, the ssr will throw warning: html content not match server html content

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: 6c60d57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@module-federation/sdk Patch
@module-federation/devtools Patch
@module-federation/dts-plugin Patch
@module-federation/enhanced Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rspack Patch
@module-federation/runtime Patch
@module-federation/utilities Patch
@module-federation/webpack-bundler-runtime Patch
3008-runtime-remote Patch
@module-federation/modernjs Patch
node-dynamic-remote-new-version Patch
node-dynamic-remote Patch
@module-federation/runtime-tools Patch
@module-federation/third-party-dts-extractor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 6c60d57
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6661a4a4665b6e0008d96da9
😎 Deploy Preview https://deploy-preview-2586--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhoushaw zhoushaw merged commit b0a31a7 into main Jun 7, 2024
@zhoushaw zhoushaw deleted the fix/no-update-existed-tag branch June 7, 2024 02:28
@2heal1 2heal1 mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants