Skip to content

Conversation

@2heal1
Copy link
Member

@2heal1 2heal1 commented May 21, 2024

Description

fix: only delete can be configurable descriptor

Related Issue

#2436

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: b381259

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@module-federation/runtime Patch
@module-federation/devtools Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/runtime-tools Patch
@module-federation/webpack-bundler-runtime Patch
node-dynamic-remote-new-version Patch
node-dynamic-remote Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
3008-runtime-remote Patch
@module-federation/modernjs Patch
@module-federation/sdk Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 21, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit b381259
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/664c1d2b89fd5c0008753d69
😎 Deploy Preview https://deploy-preview-2518--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1 2heal1 merged commit 425fc9d into main May 28, 2024
@2heal1 2heal1 deleted the fix/delete-conditional-remote branch May 28, 2024 09:07
@2heal1 2heal1 mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants