feat(sdk): auto public path support for json remote #2463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94b85a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ScriptedAlchemy
changed the title
ScriptedAlchemy
force-pushed
the
feat/manifest-auto-path
branch
from
290ddb1 to
4cdace4
Compare
ScriptedAlchemy
force-pushed
the
feat/manifest-auto-path
branch
from
4cdace4 to
edeae14
Compare
ScriptedAlchemy
commented
May 8, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ScriptedAlchemy
force-pushed
the
feat/manifest-auto-path
branch
from
ede9b15 to
b56a3d3
Compare
ScriptedAlchemy
force-pushed
the
feat/manifest-auto-path
branch
from
b56a3d3 to
67adcf1
Compare
5 tasks
Comment on lines
+52
to
+54
| return url | ||
| .replace(/#.*$/, '') | ||
| .replace(/\?.*$/, '') |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
Comment on lines
+52
to
+53
| return url | ||
| .replace(/#.*$/, '') |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
# Conflicts: # .gitignore # apps/node-local-remote/webpack.config.js
ScriptedAlchemy
commented
May 9, 2024
ScriptedAlchemy
commented
May 9, 2024
2heal1
approved these changes
May 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow manifest to be emitted with public path auto
adjust runtime plugin to look up public path off its own remote when setting remoteSnapshot into
Related Issue
#2449
Types of changes
Checklist