-
-
Notifications
You must be signed in to change notification settings - Fork 374
chore: remove duplicated section from quick-start docs #2424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| ### 3. Consuming the Producer | ||
|
|
||
| > Change the entry to be asynchronous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this part is necessary. Why delete it and consider it duplicate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section was in the page three times, once in "Creating a Consumer" but then twice in "Creating a Producer":
core/apps/website-new/docs/en/guide/start/quick-start.mdx
Lines 205 to 223 in 712d8f8
| > Change the entry to be asynchronous | |
| ```tsx | |
| // Move src/index.tsx to a newly created src/bootstrap.tsx file | |
| // src/index.tsx | |
| import('./bootstrap'); | |
| // src/bootstrap.tsx | |
| import React from 'react'; | |
| import ReactDOM from 'react-dom/client'; | |
| import App from './App'; | |
| const root = ReactDOM.createRoot(document.getElementById('root')); | |
| root.render( | |
| <React.StrictMode> | |
| <App /> | |
| </React.StrictMode>, | |
| ); | |
| ``` |
core/apps/website-new/docs/en/guide/start/quick-start.mdx
Lines 268 to 286 in 712d8f8
| > Change the entry to be asynchronous | |
| ```tsx | |
| // Move src/index.tsx to a newly created src/bootstrap.tsx file | |
| // src/index.tsx | |
| import('./bootstrap'); | |
| // src/bootstrap.tsx | |
| import React from 'react'; | |
| import ReactDOM from 'react-dom/client'; | |
| import App from './App'; | |
| const root = ReactDOM.createRoot(document.getElementById('root')!); | |
| root.render( | |
| <React.StrictMode> | |
| <App /> | |
| </React.StrictMode>, | |
| ); | |
| ``` |
I removed the first instance in the Producer section rather than the second, as it seemed like a cleaner sequence that way, but either one would work.
|
It should remain there since both apps should be in async mode. |

Types of changes
Checklist