Skip to content

Conversation

@2heal1
Copy link
Member

@2heal1 2heal1 commented Feb 5, 2024

Description

  • use upath to against more edge cases between different OS

str.replaceAll will throw error while node version below 15

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@ilteoood
Copy link
Contributor

ilteoood commented Feb 5, 2024

TBH I would avoid merging this to support a node version that is not maintained anymore.
As of now, the minimum version of node suggested is node 18.

@2heal1
Copy link
Member Author

2heal1 commented Feb 5, 2024

TBH I would avoid merging this to support a node version that is not maintained anymore. As of now, the minimum version of node suggested is node 18.

Yes, I also don't want to do it . But users may not use the latest node , and this change also allows avoid edge cases in different OS.

@zhoushaw zhoushaw merged commit 4ca0c7b into main Feb 5, 2024
@zhoushaw zhoushaw deleted the fix/downgrade-replace-all branch February 5, 2024 09:54
@2heal1 2heal1 mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants