feat: initRawContainer method #2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptedAlchemy
commented
Jan 23, 2024
| node_remote: 'node_remote@http://localhost:3002/remoteEntry.js', | ||
| // node_local_remote: '__webpack_require__.federation.instance.moduleCache.get("node_local_remote")', | ||
| node_remote: | ||
| '__webpack_require__.federation.instance.moduleCache.get("node_remote")@http://localhost:3002/remoteEntry.js', |
Member
Author
There was a problem hiding this comment.
When using script global external modules in Webpack, it searches for containers in the internal module cache, as if it were a global variable.
ScriptedAlchemy
commented
Jan 23, 2024
| container: RemoteEntryExports, | ||
| ): Module { | ||
| const remoteInfo = getRemoteInfo({ name, entry: url }); | ||
| const module = new Module({ host: this, remoteInfo }); |
Member
Author
There was a problem hiding this comment.
@2heal1, could you give me your input on this solution? I believe there are relevant use cases for when a user may sideload a container, and we need a way to convert it to a module instance.
Member
There was a problem hiding this comment.
Not encounter the case , but I think this solution is okay :D
ScriptedAlchemy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the initRawContainer method to allow sideloading or conversion of containers into wrapped modules, which can be injected into the cache. The method improves runtime and debugging.
For server use cases or dynamic scenarios, like webpack built in script loading, its possible for the container to be loaded another way or injected into the module cache by other means.
Related Issue
Types of changes
Checklist