feat: support cjs #1981
Merged
feat: support cjs #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| attrs['type'] === 'cjs' && | ||
| /^(\/|[A-Za-z]:\\|\\\\|\.\.?(\/|$))/.test(url) | ||
| ) { | ||
| const requireClient = eval('require'); |
Member
There was a problem hiding this comment.
can new Function() used here?
| 'commonjs2', | ||
| 'commonjs-module', | ||
| 'commonjs-static', | ||
| 'node-commonjs', |
Member
There was a problem hiding this comment.
in fufure we should do "internal" as well?
@jacob-ebey this would let you reference internal modules like "internal ./src/something" and get the module like webpack_require, as long as its bundled in somehow
ScriptedAlchemy
approved these changes
Jan 17, 2024
ScriptedAlchemy
approved these changes
Jan 17, 2024
ScriptedAlchemy
approved these changes
Jan 17, 2024
ScriptedAlchemy
added a commit
that referenced
this pull request
Jan 20, 2024
This reverts commit 6e0cef8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Types of changes
Checklist