Skip to content

Add a None check for exc.stdout. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Add a None check for exc.stdout. #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/stack_pr/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,8 +579,16 @@ def push_branches(st: List[StackEntry], remote):


def print_cmd_failure_details(exc: SubprocessError):
cmd_stdout = exc.stdout.decode("utf-8").replace("\\n", "\n").replace("\\t", "\t")
cmd_stderr = exc.stderr.decode("utf-8").replace("\\n", "\n").replace("\\t", "\t")
cmd_stdout = (
exc.stdout.decode("utf-8").replace("\\n", "\n").replace("\\t", "\t")
if exc.stdout
else None
)
cmd_stderr = (
exc.stderr.decode("utf-8").replace("\\n", "\n").replace("\\t", "\t")
if exc.stderr
else None
)
print(f"Exitcode: {exc.returncode}")
print(f"Stdout: {cmd_stdout}")
print(f"Stderr: {cmd_stderr}")
Expand Down Expand Up @@ -760,7 +768,9 @@ def deduce_base(args: CommonArgs) -> CommonArgs:
deduced_base = get_command_output(
["git", "merge-base", args.head, f"{args.remote}/{args.target}"]
)
return CommonArgs(deduced_base, args.head, args.remote, args.target, args.hyperlinks)
return CommonArgs(
deduced_base, args.head, args.remote, args.target, args.hyperlinks
)


def print_tips_after_export(st: List[StackEntry], args: CommonArgs):
Expand Down Expand Up @@ -1144,7 +1154,10 @@ def create_argparser() -> argparse.ArgumentParser:
"-T", "--target", default="main", help="Remote target branch"
)
common_parser.add_argument(
"--hyperlinks", action=argparse.BooleanOptionalAction, default=True, help="Enable or disable hyperlink support."
"--hyperlinks",
action=argparse.BooleanOptionalAction,
default=True,
help="Enable or disable hyperlink support.",
)

parser_submit = subparsers.add_parser(
Expand Down