Skip to content

calcconfirmsneeded repetitive #22

@joshuahannan

Description

@joshuahannan

The function calcConfirmsNeeded exists both in WalletMainLib and in WalletAdminLib, with the subtle difference of it being public in the first case and private in the second. Since the function simply performs a subtraction between its two parameters, its reason to exist is questionable. Consider (a) removing the function from WalletAdminLib and making the one in WalletMainLib private, or (b) removing the function from both places and using inlined subtractions instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions