Skip to content

Commit

Permalink
Remove stale GKE 1.27 version references (hashicorp#12093)
Browse files Browse the repository at this point in the history
[upstream:db2e60d6251d68d9cd98621e686c99078903cd24]

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician committed Oct 23, 2024
1 parent db410f4 commit d36b2cd
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 15 deletions.
2 changes: 2 additions & 0 deletions .changelog/12093.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
```release-note:none
```
11 changes: 6 additions & 5 deletions google/services/container/resource_container_cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7954,7 +7954,6 @@ resource "google_container_cluster" "with_pco_disabled" {
network = google_compute_network.container_network.name
subnetwork = google_compute_subnetwork.container_subnetwork.name
min_master_version = "1.27"
initial_node_count = 1
datapath_provider = "ADVANCED_DATAPATH"
Expand Down Expand Up @@ -9269,14 +9268,16 @@ func testAccContainerCluster_autopilot_net_admin(name, networkName, subnetworkNa
resource "google_container_cluster" "primary" {
name = "%s"
location = "us-central1"
network = "%s"
subnetwork = "%s"
enable_autopilot = true
allow_net_admin = %t
min_master_version = 1.27
deletion_protection = false
network = "%s"
subnetwork = "%s"
}
`, name, enabled, networkName, subnetworkName)
`, name, networkName, subnetworkName, enabled)
}

func TestAccContainerCluster_customPlacementPolicy(t *testing.T) {
Expand Down
22 changes: 12 additions & 10 deletions google/services/container/resource_container_node_pool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,6 @@ resource "google_compute_subnetwork" "container_subnetwork" {
resource "google_container_cluster" "cluster" {
name = "%s"
location = "us-central1-a"
min_master_version = "1.27"
initial_node_count = 1
network = google_compute_network.container_network.name
Expand Down Expand Up @@ -2440,10 +2439,11 @@ resource "google_container_cluster" "cluster" {
name = "%s"
location = "us-central1"
initial_node_count = 3
min_master_version = "1.27"
deletion_protection = false
network = "%s"
network = "%s"
subnetwork = "%s"
deletion_protection = false
}
resource "google_container_node_pool" "np" {
Expand All @@ -2466,10 +2466,11 @@ resource "google_container_cluster" "cluster" {
name = "%s"
location = "us-central1"
initial_node_count = 3
min_master_version = "1.27"
deletion_protection = false
network = "%s"
network = "%s"
subnetwork = "%s"
deletion_protection = false
}
resource "google_container_node_pool" "np" {
Expand All @@ -2496,11 +2497,12 @@ resource "google_container_cluster" "cluster" {
provider = google.user-project-override
name = "%s"
location = "us-central1"
network = "%s"
subnetwork = "%s"
initial_node_count = 3
min_master_version = "1.27"
deletion_protection = false
network = "%s"
subnetwork = "%s"
}
resource "google_container_node_pool" "np" {
Expand Down

0 comments on commit d36b2cd

Please sign in to comment.