Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Change address purposes to strings #512

Conversation

modular-magician
Copy link
Owner

I'm not sure if this actually has any user impact so there's no changelog entry, but we won't block users wanting to adopt new purposes. New ones come up too frequently for me to want to track possible values anymore.

Interestingly, comparing to https://cloud.google.com/compute/docs/reference/rest/beta/addresses and https://cloud.google.com/compute/docs/reference/rest/beta/globalAddresses, we support some purposes that don't appear there and don't support purposes that do. That's an even more clear sign we should get out of the business of tracking these.

The c.g.c page additionally doesn't disambiguate between what's available in global / regional addresses, and some of them are external so I removed the internal warning in both types.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#4681

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e2f7252 into master Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant