Fix downloading libraries for Forge 1.7.2 #4808
Merged
+29
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our library download code path we have a fallback way of creating a URL if we don't have a library URL in the game version metadata, introduced in #4494:
Even though the library is "probably not needed", we will still fatally abort if we can't download it. However, the URL is not guaranteed to even point to a real download since we're pulling it out of thin air, so this should be silently ignored (with a log message).
Also bumped up recursion limit because somehow this tiny change was enough to tip rustc over the edge with calculating Send/Sync bounds.