Skip to content

Tweaks and fixes to background tasks #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

Tweaks and fixes to background tasks #4447

merged 2 commits into from
Sep 30, 2025

Conversation

@fetchfern
Copy link
Contributor

@fetchfern fetchfern commented Sep 29, 2025 •
edited
Loading

  • Fix the email templating of payoutavailable.amount.
  • Don't run Anrok API operations in parallel of other subscriptions operations in the index_subscriptions background task.
  • Additional logging within the index_subscriptions background task
  • Don't try unprovisioning subscriptions that are already unprovisioned, this should make the index_subscriptions task a lot lighter.
  • Don't refresh the tax_amount value for charges due in over 14 days (causes Anrok API errors)

@fetchfern fetchfern requested a review from aecsocket September 29, 2025 22:09
AlexTMjugador
AlexTMjugador approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure CI passes before merging.

@fetchfern fetchfern added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit 54747aa Sep 30, 2025
3 checks passed
fetchfern added a commit that referenced this pull request Oct 1, 2025
@fetchfern
Tweaks and fixes to background tasks (#4447)
0e14ff9 
* adjustments

* chore: query cache, clippy, fmt
@Prospector Prospector deleted the fetch/email-template-fixes branch October 23, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexTMjugador AlexTMjugador AlexTMjugador approved these changes

@aecsocket aecsocket Awaiting requested review from aecsocket

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fetchfern @AlexTMjugador