Skip to content

"Create a server" tooltip i18n fixes #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

"Create a server" tooltip i18n fixes #4402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions apps/frontend/src/locales/en-US/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,11 +1148,8 @@
"project.actions.servers-promo.description": {
"message": "Modrinth Servers is the easiest way to play with your friends without hassle!"
},
"project.actions.servers-promo.monthly": {
"message": " / month"
},
"project.actions.servers-promo.pricing": {
"message": "Starting at $5{monthly}"
"message": "Starting at {price}<small> / month</small>"
},
"project.actions.servers-promo.title": {
"message": "Create a server"
Expand Down
34 changes: 21 additions & 13 deletions apps/frontend/src/pages/[type]/[id].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,9 +497,11 @@
</nuxt-link>
</ButtonStyled>
<template #popper>
<div class="experimental-styles-within flex max-w-60 flex-col gap-1">
<div class="flex items-center justify-between gap-4">
<h3 class="m-0 flex items-center gap-2 text-base font-bold text-contrast">
<div class="experimental-styles-within grid grid-cols-[min-content] gap-1">
<div class="flex min-w-60 items-center justify-between gap-4">
<h3
class="m-0 flex items-center gap-2 whitespace-nowrap text-base font-bold text-contrast"
>
{{ formatMessage(messages.serversPromoTitle) }}
<TagItem
:style="{
Expand Down Expand Up @@ -529,9 +531,18 @@
</p>

<p class="m-0 text-wrap text-sm font-bold text-primary">
{{ formatMessage(messages.serversPromoPricing, { monthly: `<span class="text-xs"
>${formatMessage(projectPageMessages.monthly)}</span
>` }) }}
<IntlFormatted
:message-id="messages.serversPromoPricing"
:values="{
price: formatPrice(locale, 500, 'USD', true),
}"
>
<template #small="{ children }">
<span class="text-xs">
<component :is="() => children" />
</span>
</template>
</IntlFormatted>
</p>
</div>
</template>
Expand Down Expand Up @@ -991,7 +1002,8 @@ import {
useRelativeTime,
} from '@modrinth/ui'
import VersionSummary from '@modrinth/ui/src/components/version/VersionSummary.vue'
import { formatCategory, formatProjectType, renderString } from '@modrinth/utils'
import { formatCategory, formatPrice, formatProjectType, renderString } from '@modrinth/utils'
import { IntlFormatted } from '@vintl/vintl/components'
import { useLocalStorage } from '@vueuse/core'
import dayjs from 'dayjs'
import { Tooltip } from 'floating-vue'
Expand Down Expand Up @@ -1024,7 +1036,7 @@ const tags = useTags()
const flags = useFeatureFlags()
const cosmetics = useCosmetics()

const { formatMessage } = useVIntl()
const { locale, formatMessage } = useVIntl()

const settingsModal = ref()
const downloadModal = ref()
Expand Down Expand Up @@ -1254,10 +1266,6 @@ const messages = defineMessages({
id: 'project.moderation.title',
defaultMessage: 'Moderation',
},
monthly: {
id: 'project.actions.servers-promo.monthly',
defaultMessage: ' / month',
},
noCollectionsFound: {
id: 'project.collections.none-found',
defaultMessage: 'No collections found.',
Expand Down Expand Up @@ -1336,7 +1344,7 @@ const messages = defineMessages({
},
serversPromoPricing: {
id: 'project.actions.servers-promo.pricing',
defaultMessage: 'Starting at $5{monthly}',
defaultMessage: 'Starting at {price}<small> / month</small>',
},
serversPromoTitle: {
id: 'project.actions.servers-promo.title',
Expand Down