Localizable Rust code (labrinth) #4367
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s containing information on how to translate
# Conflicts: # apps/labrinth/src/queue/payouts.rs # apps/labrinth/src/routes/mod.rs
# Conflicts: # apps/labrinth/src/auth/email/mod.rs # apps/labrinth/src/routes/internal/flows.rs # apps/labrinth/src/routes/mod.rs # apps/labrinth/src/routes/v2/version_file.rs
# Conflicts: # apps/labrinth/src/models/v3/notifications.rs # apps/labrinth/src/queue/email/templates.rs
…ocalized-labrinth
# Conflicts: # Cargo.toml # apps/labrinth/src/auth/checks.rs # apps/labrinth/src/models/v3/notifications.rs # apps/labrinth/src/routes/internal/affiliate.rs # apps/labrinth/src/routes/internal/billing.rs # apps/labrinth/src/routes/internal/medal.rs # apps/labrinth/src/routes/mod.rs # apps/labrinth/src/routes/v3/organizations.rs # apps/labrinth/src/routes/v3/project_creation.rs
# Conflicts: # .idea/code.iml # Cargo.lock # Cargo.toml # apps/app/Cargo.toml # apps/daedalus_client/Cargo.toml # apps/labrinth/Cargo.toml # apps/labrinth/src/models/v3/notifications.rs # apps/labrinth/src/queue/email/templates.rs # apps/labrinth/src/routes/internal/affiliate.rs # apps/labrinth/src/routes/internal/external_notifications.rs # apps/labrinth/src/routes/mod.rs # apps/labrinth/src/routes/v3/analytics_get.rs # apps/labrinth/src/routes/v3/collections.rs # packages/app-lib/Cargo.toml # packages/ariadne/Cargo.toml # packages/daedalus/Cargo.toml # rust-toolchain.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for messages returned from backend to have translation keys for the frontend to translate. This is the first of two PRs. This PR sets up the framework and integrates it into labrinth. The next PR will add it to theseus.
The PR adds a type used for translation sent from the backend:
This type is used in the following places (v3 only):
translatable_errorfield in theApiErrortypetranslatable_namefield in theNotificationtypetranslatable_textfield in theNotificationtypeIt is worth noting that a large number of these messages will never be shown to any frontend user, but to avoid making the system more complex to separate "impossible" messages from "possible" ones, all messages are localizable.